Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side menu order of page navigation breaks shrinkage #18

Open
WhatsThatItsPat opened this issue Sep 24, 2015 · 0 comments
Open

Side menu order of page navigation breaks shrinkage #18

WhatsThatItsPat opened this issue Sep 24, 2015 · 0 comments

Comments

@WhatsThatItsPat
Copy link

First off, thanks for your work. Now onto the issues.

I've been troubleshooting Scroll Sista when used with the Side Menu and have come across a few issues. I'll submit them separately but I'll use the same Codepen for demonstration.

http://codepen.io/patrickmcd/pen/JYRLrb

This issue is that header shrinkage breaks depending on the order you navigate the side menu. Go to the Codepen and try the following.

Order 1:

  1. Start on A: Header shrinks
  2. Go to B: Header shrinks
  3. Go to C: Shrinking breaks

Maybe there's something wrong with C, you'll think, but they actually share the same template. Reload page and then Order 2 (just swap B and C):

  1. Start on A: Header shrinks
  2. Go to C: Header shrinks
  3. Go to B: Shrinking breaks

Now C works and B has the issue. The issue is that the 3rd page you get to doesn't work. But now try this next one. Reload page and then Order 3:

  1. Start on A: Header shrinks
  2. Go to B: Header shrinks
  3. Now return to page A: Header still works
  4. Go to C: Header works.

They are all working here, but I can break it again. Reload page and then Order 4:

  1. Start on A: Header shrinks
  2. Go to B: Header shrinks
  3. Now return to page A: Header still works
  4. Back to B: Header still works
  5. Go to C: Shrinking breaks

So it appears that if you navigate to B or C for the first time directly from A, everything is fine. But if the first time you get to B or C is not via the landing page, it breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant