Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛬 [INBOUND] - django-simple-history #131

Open
4 of 5 tasks
ddabble opened this issue Dec 7, 2024 · 16 comments
Open
4 of 5 tasks

🛬 [INBOUND] - django-simple-history #131

ddabble opened this issue Dec 7, 2024 · 16 comments

Comments

@ddabble
Copy link
Member

ddabble commented Dec 7, 2024

What's the URL to the project?

https://github.com/jazzband/django-simple-history

Who are the current maintainers?

Active:

@ddabble and @tim-schilling

Project leads:

@treyhunner and @rossmechanic

Other maintainers:

@jeking3 @thisisazeez @LeMinaw @valberg @brylie @johanneswilm @thesayfulla @mraza007

Does the project have the required attributes?

Who will be the new maintainers of the project?

@ddabble and @tim-schilling, as mentioned in jazzband/django-simple-history#1391 (comment)

Do you use test PyPI or want to test the packaging process?

  • Does the project have a test.pypi.org project?
  • Would you like to test your deployments with uploads to test.pypi.org (you'll need to create the project first)?
    • Sounds like something that could be useful, but I'm not familiar with this at all 😅

Related Issues

Copy link

github-actions bot commented Dec 7, 2024

User django-simple-history does not exist.

@ddabble
Copy link
Member Author

ddabble commented Dec 7, 2024

Whoops, pressed enter by accident 😅 Hold on while I edit the description..

@tim-schilling
Copy link
Member

tim-schilling commented Dec 10, 2024

@ddabble correct me if I'm wrong about the merge options:

"django-simple-history" = {
  description = "Store model history and view/revert changes from admin site. "
  allow_merge_commit = true # Allow merge commits on pull requests
  allow_rebase_merge = false # Allow rebase and merge commits on pull requests
  allow_squash_merge = true # Allow squash and merge commits on pull requests
  allow_update_branch = true # Allow updating source branch on pull requests
  admins = [
    # Include people who can release new versions
    "ddabble",
    "tim-schilling",
  ]
  committers = [
    # Include people who can commit to main / merge changes
  ]
  members = [
    # Include people who can assign/triage tickets
  ]
}

@tim-schilling
Copy link
Member

@treyhunner any chance you have owner permissions for one or both of the the pypi.org and test.pypi.org projects?

@tim-schilling
Copy link
Member

tim-schilling commented Dec 10, 2024

I should have clarified, can you add cunla (Daniel), stormheg (Storm) and CodenameTim (myself)? We will take over ownership of the project on the PyPI sites. This would involve removing folks after 30 days who are not on the repo's administrators team (currently it's @ddabble and I).

@ddabble if you have an account on those sites, can you please list it as well?

@ddabble
Copy link
Member Author

ddabble commented Dec 10, 2024

@ddabble correct me if I'm wrong about the merge options:
[...]

(Am I understanding it correctly that this is some textual configuration of the repo settings?)
Sure, that looks good, though a personal preference is to not use rebase merging, as rebasing usually makes it more difficult getting a picture of which commits came from which PR. So I'd vote for setting allow_rebase_merge = false, but I'm fine with whatever 🙂

@ddabble
Copy link
Member Author

ddabble commented Dec 10, 2024

@ddabble if you have an account on those sites, can you please list it as well?

Yes, it's dabble on both sites :) (PyPI; TestPyPI)

@tim-schilling
Copy link
Member

You're understanding of that config is correct!

And interesting, I tend to like the rebase option because I find the merge commits a bit awkward and confusing compared to a linear history. I'm good with removing it though. It'll force me to try something new (my theme for 2025).

@treyhunner
Copy link

I should have clarified, can you add cunla (Daniel), stormheg (Storm) and CodenameTim (myself)? We will take over ownership of the project on the PyPI sites. This would involve removing folks after 30 days who are not on the repo's administrators team (currently it's @ddabble and I).

@ddabble if you have an account on those sites, can you please list it as well?

I wasn't sure whether you needed maintainer or owner access. I've added cunla, stormheg, dabble as maintainers and CodenameTim as an owner. @tim-schilling feel free to increase the access privileges of all as needed.

Would brianarmstrong, kyledseever, rossmechanic, ThePumpingLemma, macro1, and jazzband (and possibly me) be removed from the PyPI after 30 days as well? Or would the project leads stay on PyPI also?

@Stormheg
Copy link
Member

Stormheg commented Dec 14, 2024

@treyhunner, I just received the PyPI invite - thank you 👍

However, it permits us maintainer access only. Are you able to change our roles to owner?

Edit: I see you changed it, thanks! @tim-schilling did not explicitly mention what access we need, but it should always be 'owner' so we can properly administer.

@treyhunner
Copy link

@treyhunner, I just received the PyPI invite - thank you 👍

However, it permits us maintainer access only. Are you able to change our roles to owner?

I was able to increase access for all but @ddabble. They'll need to accept the pending invite before someone can increase access from maintainer to owner.

@ddabble
Copy link
Member Author

ddabble commented Dec 14, 2024

@treyhunner, I just received the PyPI invite - thank you 👍

However, it permits us maintainer access only. Are you able to change our roles to owner?

I was able to increase access for all but @ddabble. They'll need to accept the pending invite before someone can increase access from maintainer to owner.

Accepted now :)

@treyhunner
Copy link

@treyhunner, I just received the PyPI invite - thank you 👍
However, it permits us maintainer access only. Are you able to change our roles to owner?

I was able to increase access for all but @ddabble. They'll need to accept the pending invite before someone can increase access from maintainer to owner.

Accepted now :)

Just made you an owner 👍

@tim-schilling
Copy link
Member

Would brianarmstrong, kyledseever, rossmechanic, ThePumpingLemma, macro1, and jazzband (and possibly me) be removed from the PyPI after 30 days as well? Or would the project leads stay on PyPI also?

@treyhunner Yes, that would be the plan. Any of you are welcome to opt-in to staying on as an admin though! I don't believe anyone has over the few issues that exist, so @ddabble have been operating with the understanding that we would take over management of the repo.

@macro1
Copy link

macro1 commented Dec 14, 2024

it's been quite a while since i've been actively involved. happy to help if the need is there, but the project seems to be in capable hands with @ddabble and @rossmechanic before that. i'm fine to have my access decreased or removed if that's what you all think is best

@ddabble
Copy link
Member Author

ddabble commented Dec 15, 2024

Thank you for your trust, @macro1, and also to you other guys for entrusting me with PyPI ownership! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants