Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: workflow to build example hosts #457

Open
montchr opened this issue Apr 24, 2022 · 0 comments
Open

ci: workflow to build example hosts #457

montchr opened this issue Apr 24, 2022 · 0 comments
Labels
ci Workflow automation enhancement New feature or request

Comments

@montchr
Copy link
Collaborator

montchr commented Apr 24, 2022

Would your feature fix an existing issue?

As pointed out in #438 (comment), CI checks can pass but example host configurations can still fail to build. This indicates a gap in our CI workflows.

From that comment:

nix flake check  # this works on the current revision
nix flake show   # this also works on the current revision
nix build .#darwinConfigurations.Mac.system

The last step returns:

error: The option `environment.shellAliases.nrb' has conflicting definition values:
       - In `/nix/store/3qc2jan7bjahmiv9h3p84r1ymkkcla8q-source/profiles/core/common.nix': "sudo > darwin-rebuild"
       - In `/nix/store/3qc2jan7bjahmiv9h3p84r1ymkkcla8q-source/profiles/core/darwin.nix': "sudo > darwin-rebuild switch --flake"

Describe the solution you'd like

I've fixed the direct issue in #438 for the time being, but ideally we should run nix build for the key example hosts in each of the examples.

Since building the host configurations would likely be more time- and resource-intensive than simply running the existing checks, it'd be best to tune the CI workflows to only build hosts when changes to their respective examples could affect the hosts' buildability.

Describe alternatives you've considered

If there's a way to catch errors like the one mentioned above without nix build, that would probably be preferable.

@montchr montchr added the enhancement New feature or request label Apr 24, 2022
@montchr montchr added the ci Workflow automation label Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Workflow automation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant