From 9bb7a036515fb01924fa41293fa65a882e82df18 Mon Sep 17 00:00:00 2001 From: Peter Portante Date: Fri, 8 Apr 2022 16:31:14 -0400 Subject: [PATCH] Code review feedback fixes --- agent/bench-scripts/pbench-linpack | 3 +-- agent/bench-scripts/tests/pbench-linpack/test-65.pre | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/agent/bench-scripts/pbench-linpack b/agent/bench-scripts/pbench-linpack index 603bcce489..0e254fa3dc 100755 --- a/agent/bench-scripts/pbench-linpack +++ b/agent/bench-scripts/pbench-linpack @@ -132,7 +132,7 @@ function store_and_run { local cmd=${2} local filename=${3} ( - cd "${1}" && + cd "${workdir}" && echo "${cmd}" > "${filename}" && chmod +x "${filename}" && "./${filename}" &> "${filename}.out" @@ -197,7 +197,6 @@ trap "interrupt" INT QUIT TERM let count=1 for thread in ${threads//,/ }; do iteration="${count}-${thread}-threads" - echo ${iteration} >> ${benchmark_iterations} iteration_dir="${benchmark_run_dir}/${iteration}" mkdir -p "${iteration_dir}" record_iteration ${count} ${thread} ${iteration} diff --git a/agent/bench-scripts/tests/pbench-linpack/test-65.pre b/agent/bench-scripts/tests/pbench-linpack/test-65.pre index ec0dd5795a..6e77181a0e 100755 --- a/agent/bench-scripts/tests/pbench-linpack/test-65.pre +++ b/agent/bench-scripts/tests/pbench-linpack/test-65.pre @@ -1,6 +1,6 @@ #!/bin/bash -# Setup a fake install of linpack but without the expected executable. +# Setup a fake install of linpack but with a stub for the expected executable. _linpack_dir=${_testtmp}/linpack mkdir ${_linpack_dir} || exit 1 printf -- "#!/bin/bash\nexit 0\n" > ${_linpack_dir}/xlinpack_xeon64 || exit 1