Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all HTTP methods are supported #492

Closed
kubukoz opened this issue Oct 5, 2022 · 2 comments · Fixed by #493
Closed

Not all HTTP methods are supported #492

kubukoz opened this issue Oct 5, 2022 · 2 comments · Fixed by #493
Assignees
@kubukoz
Labels
bug Something isn't working
Milestone
0.17.0

Comments

@kubukoz
Copy link
Member

kubukoz commented Oct 5, 2022

e.g. @http(method: "HEAD") results in HttpMethod.fromString failing, thus causing e.g. the creation of a http4s client to throw with s"Operation ${endpoint.name} is not bound to http semantics".
@kubukoz kubukoz added the bug Something isn't working label Oct 5, 2022
@kubukoz
Copy link
Member Author

kubukoz commented Oct 5, 2022

Side note, that error message can really be quite confusing - another case of Option being harmful for error handling 😅

@kubukoz kubukoz self-assigned this Oct 5, 2022
@kubukoz kubukoz mentioned this issue Oct 6, 2022
Merged
@kubukoz
Copy link
Member Author

kubukoz commented Nov 10, 2022

Closed in #493

@kubukoz kubukoz closed this as completed Nov 10, 2022
@kubukoz kubukoz added this to the 0.17.0 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kubukoz kubukoz

Labels
bug Something isn't working
Projects
None yet
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

Support more HTTP methods, keep more details about HTTP matching failures disneystreaming/smithy4s
1 participant
@kubukoz