-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrease timestamp resolution #1598
Comments
I don't want to change the default behaviour of serialising as much information as possible, which prevents loss of information. Generally speaking, I think tools ought to abide by some level of lenience when it comes to de-serialisation, but provide as much info as available when it comes to serialisation. I'm happy to accept changes of behaviour that go in that direction, but not willing to make changes that go in the other direction. That being said :
|
I like the ability to customize and a |
Actually, |
I meant methods on Timestamp for starters, but we could later on create corresponding traits. I wouldn't want to pull that trigger unless there's a non-hypothetical scenario that'd warrant it. |
Long story short the change in #1576 prompted me to review in details
timestamp
datatype andtimestampFormat
trait.According to smithy documentation:
and timestamp format docs
For
date-time
andepoch-seconds
:For
http-date
:Base on the above I propose following changes:
timestampFormat=http-date
the value should be truncated to second precision during the serializationtimestampFormat=date-time | epoch-seconds
the value should be truncated to millisecond precision during the serializationThe text was updated successfully, but these errors were encountered: