required=True takes in empty values

[czue]

class MyObject(JsonObject):
    required_thing = StringProperty(required=True)

MyObject.wrap({'required_thing': ''})  # this doesn't fail ... should it?

[dannyroberts]

Good question. I just documented the intended behavior here: #104.

[dannyroberts]

Specifically in required under https://github.com/dimagi/jsonobject/blob/document-property-args/README.md#property-options.

[czue]

i would argue that accepting an empty string is surprising and confusing, but won't push too hard on it.

[czue]

maybe could add blank=True similar to djangos CharField

[dannyroberts]

Good feedback, and I'll keep that in the back of my mind as I rework.
Generally, this library is used so heavily in our code that all api
behaviors, even strange ones, are relied upon somewhere, so it has to be
done thoughtfully.
On Sep 25, 2014 12:32 PM, "Cory Zue" [email protected] wrote:

i would argue that accepting an empty string is surprising and confusing,
but won't push too hard on it.

—
Reply to this email directly or view it on GitHub
#103 (comment).

[dannyroberts]

Leaving this issue open as a reminder to implement blank=True option:

class MyObject(JsonObject):
    not_blank_thing = StringProperty(blank=True)

>>> MyObject.wrap({'not_blank_thing': ''})
...
BadValueError: Property not_blank_thing cannot be blank.