Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename a few reports js files #35513

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Rename a few reports js files #35513

merged 3 commits into from
Dec 12, 2024

Conversation

orangejenny
Copy link
Contributor

Technical Summary

Webpack tends to dislike files with . in the middle. This PR renames a few such files to simplify the eventual migration of reports to webpack.

Safety Assurance

Safety story

This is a mechanical change. Code review should be sufficient.

Automated test coverage

little if any

QA Plan

Not requesting QA

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@orangejenny orangejenny added the product/invisible Change has no end-user visible impact label Dec 11, 2024
@dimagimon dimagimon added the Risk: Medium Change affects files that have been flagged as medium risk. label Dec 11, 2024
@orangejenny
Copy link
Contributor Author

I'm not fixing the pre-existing lint errors in maps_utils because that would increase the testing necessary for this PR.

@orangejenny orangejenny merged commit fc93a79 into master Dec 12, 2024
12 of 13 checks passed
@orangejenny orangejenny deleted the jls/js-renames branch December 12, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millerdev millerdev millerdev approved these changes

@gherceg gherceg Awaiting requested review from gherceg

@jingcheng16 jingcheng16 Awaiting requested review from jingcheng16

@calellowitz calellowitz Awaiting requested review from calellowitz calellowitz is a code owner

@biyeun biyeun Awaiting requested review from biyeun biyeun is a code owner

Assignees
No one assigned
Labels
product/invisible Change has no end-user visible impact Risk: Medium Change affects files that have been flagged as medium risk.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orangejenny @millerdev @dimagimon