Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove polynomial regexps #35487

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Remove polynomial regexps #35487

merged 1 commit into from
Dec 6, 2024

Conversation

esoergel
Copy link
Contributor

@esoergel esoergel commented Dec 6, 2024

Product Description

Technical Summary

https://dimagi.atlassian.net/browse/USH-5178

relates to https://dimagi.atlassian.net/browse/SAAS-16188

https://github.com/dimagi/commcare-hq/security/code-scanning/273 https://github.com/dimagi/commcare-hq/security/code-scanning/361 https://github.com/dimagi/commcare-hq/security/code-scanning/363

 isdigit() method of builtins.str instance
     Return True if the string is a digit string, False otherwise.

     A string is a digit string if all characters in the string are digits and there
     is at least one character in the string.

Feature Flag

Safety Assurance

Safety story

The commtrack one is well covered by tests, the others I verified locally

Automated test coverage

QA Plan

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

https://github.com/dimagi/commcare-hq/security/code-scanning/273
https://github.com/dimagi/commcare-hq/security/code-scanning/361
https://github.com/dimagi/commcare-hq/security/code-scanning/363

 isdigit() method of builtins.str instance
     Return True if the string is a digit string, False otherwise.

     A string is a digit string if all characters in the string are digits and there
     is at least one character in the string.

The commtrack one is well covered by tests, the others I verified
locally
@dimagimon dimagimon added the Risk: High Change affects files that have been flagged as high risk. label Dec 6, 2024
Copy link

sentry-io bot commented Dec 6, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: corehq/apps/users/views/mobile/users.py

Function Unhandled Issue
post WorkbookTooManyRows /a/{domain}/settings/users/co...
Event Count: 13

Did you find this useful? React with a 👍 or 👎

@esoergel esoergel marked this pull request as ready for review December 6, 2024 17:29
@esoergel esoergel merged commit 873031e into master Dec 6, 2024
11 of 13 checks passed
@esoergel esoergel deleted the es/poly-regex branch December 6, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Risk: High Change affects files that have been flagged as high risk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants