Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource Table locks on a static protective flag #646

Open
ctsims opened this issue Sep 21, 2017 · 0 comments
Open

Resource Table locks on a static protective flag #646

ctsims opened this issue Sep 21, 2017 · 0 comments
Assignees

Comments

@ctsims
Copy link
Member

ctsims commented Sep 21, 2017

There are a few places in the code where CommCare is pretty sloppy with using static locks.

I just fixed one here:
https://github.com/dimagi/commcare-core/pull/645/files#diff-a5c25a223fdbfdb01034706e5380d1c4L29

which was preventing multiple nodeset lookups from happening simultaneously

I think it may be the case that this one:

protected final static Object updateLock = new Object();

Is a huge source of "silent" concurrent locking for formplayer.

The implication of this would be that while using formplayer, only one web request would be able to be manipulating the state of an app at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants