Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt text for icons #1399

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Alt text for icons #1399

merged 3 commits into from
Feb 2, 2024

Conversation

nospame
Copy link
Contributor

@nospame nospame commented Jan 26, 2024

Product Description

Adds parsing and model storage for an alt_text node in the suite, which uses a regular text element to map to text strings. This element is expected to appear as part of a field and is nullable since it is not automatically set in HQ.

Technical Summary

USH-3933
dimagi/commcare-hq#34044
dimagi/formplayer#1536

Safety Assurance

Safety story

Automated test coverage

Added a test for parsing alt_text node and returning correct value from app strings.

QA Plan

QA with the other linked PRs.

Special deploy instructions

To be deployed as part of dimagi/formplayer#1536.

Rollback instructions

Would be rolled back as part of dimagi/formplayer#1536.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

Duplicate PR

Automatically duplicate this PR as defined in contributing.md.

@Robert-Costello
Copy link
Contributor

Robert-Costello commented Feb 1, 2024

This is probably a good place for a test

the test suite is this references is here: src/test/resources/app_structure/suite.xml

@nospame nospame merged commit c533b16 into formplayer Feb 2, 2024
2 checks passed
@nospame nospame deleted the em/icons-alt-text branch February 2, 2024 00:00
@nospame nospame mentioned this pull request Feb 21, 2024
2 tasks
@shubham1g5
Copy link
Contributor

@nospame can we add the change to the suite doc as well ?

@shubham1g5 shubham1g5 restored the em/icons-alt-text branch March 18, 2024 21:12
@shubham1g5
Copy link
Contributor

duplicate this PR 065c4d3 9cf8c64

@nospame
Copy link
Contributor Author

nospame commented Mar 18, 2024

@nospame can we add the change to the suite doc as well ?

Sure, will add that in the next day or two. Sorry, I wasn't aware of this doc before now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants