Jt/visually segmented case search group #1389
Conversation
|
Can we populate PR description to facilitiate review here. Thanks! |
| @Override | ||
| public QueryGroup parse() throws InvalidStructureException, IOException, XmlPullParserException, | ||
| UnfullfilledRequirementsException { | ||
| checkNode("group"); |
There was a problem hiding this comment.
Should this use NAME_PROMPT?
| while (nextTagInBlock(NAME_PROMPT)) { | ||
| if (NAME_DISPLAY.equalsIgnoreCase(parser.getName())) { | ||
| display = parseDisplayBlock(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you explain what this block is doing? It seems like display may get set multiple times here, not sure to what end.
There was a problem hiding this comment.
The suite would look like this for a group block. nextTagInblock iterates through the elements within group (it automatically iterates to the next element within the block without needing to increment anything in the body of the while loop). The first would be display and that whole display block will be parsed via parseDisplayBlock. The parsed values will then be used to created an instance of QueryGroup so that instance can be used to pull values as needed.
<group key="group_header_0">
<display>
<text>
<locale id="search_property.m0.group_header_0"/>
</text>
</display>
</group>
You're right that if there were multiple display blocks in the group element, only the last display block will be saved. But there should be only one
…queryPrompts so utillizes order of queryPrompts
Product Description
Parses the
groupblock and populates a newqueryGroupmodel. Also parses agroup_keyfrompromptblock and stores that inqueryPromptmodel. Both are added to theRemoteQueryDatum.Technical Summary
Tech Spec
Jira Ticket
Research Doc
Formplayer PR: dimagi/formplayer#1511
HQ PR: dimagi/commcare-hq#33828
Safety Assurance
Safety story
Locally tested.
In parsing suite, the new
groupblock andgroup-keyforpromptblock are optional so will not affect existing applications where these blocks do not exist.groupKeyinqueryPromptmodel is nullable.groupPromptspassed toremoteQueryDatumis instantiated as empty OrderedHashtable.Automated test coverage
Will add tests
QA Plan
Will QA
Special deploy instructions
Rollback instructions
Review
Duplicate PR
Automatically duplicate this PR as defined in contributing.md.