Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/vec 35 allow vector app to work #9

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,11 @@ vic-gateway: go_deps
--user $(UID):$(GID) \
armbuilder \
upx build/vic-gateway

upload-on-vector:
@ssh root@$(ROBOT_IP) "mount -o remount,rw /"
@ssh root@$(ROBOT_IP) "systemctl stop vic-cloud"
@ssh root@$(ROBOT_IP) "systemctl stop vic-gateway"
@scp ./build/vic-cloud root@$(ROBOT_IP):/anki/bin/vic-cloud
@scp ./build/vic-gateway root@$(ROBOT_IP):/anki/bin/vic-gateway
@ssh root@$(ROBOT_IP) "systemctl daemon-reload"
15 changes: 15 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,21 @@ To build vic-gateway, run...
```
# make vic-gateway
```
## Development
If you have vector with ssh enabled you can you use the following to easily upload the
generated binaries.

```
# make upload-on-vector
```

The make command assumes that you have the robot ip saved under the ROBOT_IP, which is
a comman practise while developing on vector robots. If you dont have that setup you can
use the following.

```
# make upload-on-vector ROBOT_IP=192.168.65.97
```

## Example Customization

Expand Down
2 changes: 1 addition & 1 deletion internal/voice/stream/connect.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func (strm *Streamer) newChipperConn(ctx context.Context) (Conn, *CloudError) {
},
}

otaURL = "https://" + config.Env.Check + suffix
otaURL = "http://" + config.Env.Check + suffix
Copy link

@urastogi885 urastogi885 Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this anymore.
With the 1.8 escape pod update, escape pod runs fake https so Vector can at least send HTTPS GET request to escape pod.
The additions to makefile and readme might still be useful.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right

req, err = http.NewRequest("HEAD", otaURL, nil)
if err != nil {
log.Println("Error creating CDN server https head request:", err)
Expand Down