Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on focus behaviour #833

Closed
Tracked by #395
mrosvik opened this issue Sep 19, 2023 · 10 comments
Closed
Tracked by #395

Decide on focus behaviour #833

mrosvik opened this issue Sep 19, 2023 · 10 comments
Assignees
Labels
🕵️ investigate Needs investigation

Comments

@mrosvik
Copy link
Member

mrosvik commented Sep 19, 2023

Should focus be visible only for tab navigation or when clicking with mouse as well? Today we do this different in radio (no focus visible on click), and on buttons (focus visible on click). Is it okey to do it different for different components, or should this be consistent?

Nav have used keyboard only, while Gov UK have used the same focus style for keyboard and mouse.

More info about focus from GovUK: https://design-system.service.gov.uk/get-started/focus-states/

@mrosvik mrosvik converted this from a draft issue Sep 19, 2023
@mrosvik
Copy link
Member Author

mrosvik commented Sep 19, 2023

@Camulos Vi tar et møte for å lande denne oppførselen. Vil du være med?

@mrosvik mrosvik moved this from 🔵 Inbox to 📄 Todo in Team Design System Sep 19, 2023
@mrosvik
Copy link
Member Author

mrosvik commented Sep 22, 2023

Nav har endret oppførsel på focus til at det kun er tastatur-fokus som er veldig tydelig med høy kontrast, mens mus-fokus er stylet til å matche designspråket bedre.

Dette gjøres med :focus-visible
https://hidde.blog/focus-visible-more-than-keyboard/

Det begrunnes med at "Det gir ikke mening å sette focus på en knapp man allerede har sett og trykket på"

Eller gjør det det, for at bruker skal få en bekreftelse på at de traff og hvor de er?

Brukertester med svaksynte som bruker musepeker til å navigere med:

@mrosvik
Copy link
Member Author

mrosvik commented Sep 26, 2023

Møte 26.09.23
@Camulos @mimarz @Febakke @Thuneer @mrosvik

  • Ønsker vi å skille på vanlig fokus og tastaturfokus? Fordelen med å skille dem er at vi da kan gjøre tastaturfokus ekstra synlig, mens har vi bare en så kan vi ikke være like tydelige

Fokus kan enten ha

  • Svart og gul ramme
  • Gul bakgrunn og svart underline
  • Gul bakgrunn og svart ramme

@mrosvik
Copy link
Member Author

mrosvik commented Oct 6, 2023

Vi trenger et nytt møte for å lande dette @Camulos @Thuneer @Febakke

Alternativ 1) Vi kan bruke veldig tydelig fokus ved tastaturnavigering dersom vi skjuler den ved klikk (focus-visible).
Alternativ 2) Bruke litt mindre tydelig fokus som er synlig hele tiden også ved klikk.

@mrosvik mrosvik added the 🕵️ investigate Needs investigation label Oct 6, 2023
@Thunear
Copy link
Collaborator

Thunear commented Oct 6, 2023

Laga til ein prototype der man kan velge mellom dei ulike variantane og sjå korleis det ser ut.
Legger den til her i tilfelle me kan bruke den i diskusjoner: https://thuneer.github.io/react-focus/#/
Sider: /, /innovasjon, /innovasjon/stimulab, /innovasjon/startoff, /login, /dashboard.

Kan bytte mellom states oppe til venstre:
Only-focus-visible: Kun tastatur fokus.
Focus-descrete: Focus med outline.
Focus-heavy: Focus der bakgrunssfarge endrer seg.

@Camulos
Copy link
Contributor

Camulos commented Oct 6, 2023

Min egen preferanse på dem blir Focus-descrete. Kanskje heavy kun på tekst

@mimarz
Copy link
Collaborator

mimarz commented Oct 31, 2023

Meeting 31.10.23

@mrosvik will schedule a new meeting for this

@mimarz mimarz moved this from 📄 Todo to 👀 Ready for review in Team Design System Jan 4, 2024
@mimarz
Copy link
Collaborator

mimarz commented Jan 10, 2024

We talked about update Link to only show focus on keyboard interaction/navigation.

@mrosvik mrosvik moved this from 👀 Ready for review to 🏗 In progress in Team Design System Jan 10, 2024
@mrosvik
Copy link
Member Author

mrosvik commented Jan 10, 2024

We have received feedback that it is disturbing with the yellow background that appears when clicking on links, so we need to discuss whether we can use the yellow style only for keyboard navigation for some components. @Camulos @Thuneer

@mimarz mimarz moved this from 🏗 In progress to 👀 Ready for review in Team Design System Jan 16, 2024
@mrosvik
Copy link
Member Author

mrosvik commented Jan 19, 2024

Møte 19.01.24
Deltakere: @mimarz @Camulos @Thuneer @Febakke @mrosvik

Beslutninger:

@mrosvik mrosvik closed this as completed Jan 19, 2024
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Design System Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕵️ investigate Needs investigation
Projects
Archived in project
Development

No branches or pull requests

5 participants