Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type is used by default in react package downstream #2837

Closed
mimarz opened this issue Nov 26, 2024 · 1 comment
Closed

Wrong type is used by default in react package downstream #2837

mimarz opened this issue Nov 26, 2024 · 1 comment
Labels
🐛 bug Something isn't working react @digdir/designsystemet-react

Comments

@mimarz
Copy link
Collaborator

mimarz commented Nov 26, 2024

This was on Tag component, but also present in Card. Suspect this also affects other components.

We are missing the option for other string being used on data-color.

Image

Also tested adding types to tsconfig in downstream project without success:

  "compilerOptions": {
    "types": [
      "@digdir/designsystemet-react/react-types.d.ts",
      "@digdir/designsystemet-react/colors"
    ],
  },
@mimarz mimarz converted this from a draft issue Nov 26, 2024
@mimarz mimarz added 🐛 bug Something isn't working react @digdir/designsystemet-react labels Nov 26, 2024
@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Design System Nov 26, 2024
@mimarz
Copy link
Collaborator Author

mimarz commented Dec 12, 2024

Tested with 1.0.0-next.41 and types work correctly now

@mimarz mimarz closed this as completed Dec 12, 2024
@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Design System Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working react @digdir/designsystemet-react
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant