Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The icon on button becomes very small in some cases #2611

Closed
mrosvik opened this issue Oct 15, 2024 · 0 comments · Fixed by #2612
Closed

The icon on button becomes very small in some cases #2611

mrosvik opened this issue Oct 15, 2024 · 0 comments · Fixed by #2612
Assignees
@Barsnes
Labels
🐛 bug Something isn't working react @digdir/designsystemet-react

Comments

@mrosvik
Copy link
Member

mrosvik commented Oct 15, 2024 •
edited
Loading

The icon becomes to small when the screen is smal and the text contains multiple lines.

Example from storybook (next):

Image
@mrosvik mrosvik converted this from a draft issue Oct 15, 2024
@mrosvik mrosvik added the 🐛 bug Something isn't working label Oct 15, 2024
@mimarz mimarz added the react @digdir/designsystemet-react label Oct 15, 2024
@Barsnes Barsnes self-assigned this Oct 15, 2024
@Barsnes Barsnes moved this from 🔵 Inbox to 🏗 In progress in Team Design System Oct 15, 2024
@Barsnes Barsnes mentioned this issue Oct 15, 2024
Merged
@Barsnes Barsnes moved this from 🏗 In progress to 👀 Ready for review in Team Design System Oct 15, 2024
Barsnes added a commit that referenced this issue Oct 15, 2024
@Barsnes @mimarz
chore(button): add flex-shrink to SVG and images (#2612)
6c35bb3 
resolves #2611

![image](https://github.com/user-attachments/assets/825d154e-3127-4531-a92b-2ddf179081bf)

---------

Co-authored-by: Michael Marszalek <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Design System Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Barsnes Barsnes

Labels
🐛 bug Something isn't working react @digdir/designsystemet-react
Projects
Team Design System
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(button): add flex-shrink to SVG and images digdir/designsystemet
3 participants
@mimarz @mrosvik @Barsnes