Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Border-radius: Special cases that our current system cant handle #2589

Open
Febakke opened this issue Oct 9, 2024 · 2 comments
Open

Border-radius: Special cases that our current system cant handle #2589

Febakke opened this issue Oct 9, 2024 · 2 comments
Labels
documentation/code For documentation related to code and technical specifications $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme

Comments

@Febakke
Copy link
Member

Febakke commented Oct 9, 2024

We need to find a solution for special cases that we cant predict

For example:
All buttons have 9999 border-radius
Everything else have 0

This is impossible with todays system

@Febakke Febakke converted this from a draft issue Oct 9, 2024
@Febakke Febakke added the $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme label Oct 9, 2024
@mimarz
Copy link
Collaborator

mimarz commented Oct 17, 2024

We can use component tokens or just plain css to achieve this. #2287

:root {
 --ds-border-radius-base: 0
}

.ds-button {
 border-radius: var(--ds-border-radius-full);
}

Image

@mimarz mimarz added 📝 article documentation/code For documentation related to code and technical specifications and removed 📝 article labels Oct 17, 2024
@mimarz
Copy link
Collaborator

mimarz commented Oct 17, 2024

We want to document this somewhere on how to do this in Figma and Code. Might be part of documentation for border-radius tokens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation/code For documentation related to code and technical specifications $ tokens Everything related to tokens and Work related to @digdir/designsystemet-theme
Projects
Status: 📄 Todo
Development

No branches or pull requests

2 participants