Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic theme css files #2556

Closed
Barsnes opened this issue Oct 2, 2024 · 0 comments · Fixed by #2560
Closed

Deterministic theme css files #2556

Barsnes opened this issue Oct 2, 2024 · 0 comments · Fixed by #2560
Assignees
@unekinn
Labels
🐛 bug Something isn't working ✨enhancement

Comments

@Barsnes
Copy link
Member

Barsnes commented Oct 2, 2024

The brand files created when doing yarn build:tokens does not spit out css in the same order every time.

This is not an issue when using the brand file.

It would be better to have a set format for the file so we don't get unnecessary git changes
@github-project-automation github-project-automation bot moved this to 🔵 Inbox in Team Design System Oct 2, 2024
@Barsnes Barsnes added 🐛 bug Something isn't working ✨enhancement labels Oct 2, 2024
@unekinn unekinn self-assigned this Oct 2, 2024
@unekinn unekinn mentioned this issue Oct 2, 2024
Merged
@unekinn unekinn moved this from 🔵 Inbox to 👀 Ready for review in Team Design System Oct 2, 2024
@unekinn unekinn closed this as completed in 5fe5050 Oct 3, 2024
@github-project-automation github-project-automation bot moved this from 👀 Ready for review to ✅ Done in Team Design System Oct 3, 2024
unekinn added a commit that referenced this issue Oct 11, 2024
@unekinn
fix(cli): the internal order of the parts of the built css files was …
ca364ea 
…nondeterministic (#2560)

Closes #2556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unekinn unekinn

Labels
🐛 bug Something isn't working ✨enhancement
Projects
Team Design System
Status: ✅ Done
Milestone
No milestone
2 participants
@unekinn @Barsnes