Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topp align checkbox and radio #2459

Closed
Tracked by #2311
eirikbacker opened this issue Sep 19, 2024 · 1 comment · Fixed by #2607
Closed
Tracked by #2311

Topp align checkbox and radio #2459

eirikbacker opened this issue Sep 19, 2024 · 1 comment · Fixed by #2607
Labels
🐛 bug Something isn't working css @digdir/designsystemet-css
Milestone
Helhetlig kompone...

Comments

@eirikbacker
Copy link
Contributor

Issue reported by team in Mattilsynet:Image
@eirikbacker eirikbacker converted this from a draft issue Sep 19, 2024
@eirikbacker eirikbacker added the css @digdir/designsystemet-css label Sep 19, 2024
@mimarz mimarz added the 🐛 bug Something isn't working label Sep 24, 2024
@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Design System Sep 24, 2024
@eirikbacker
Copy link
Contributor Author

Should be done with #2311

@eirikbacker eirikbacker mentioned this issue Sep 25, 2024
Closed
@eirikbacker eirikbacker mentioned this issue Oct 23, 2024
Merged
@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Design System Oct 24, 2024
Barsnes added a commit that referenced this issue Oct 28, 2024
@Barsnes
Squashed commit of the following:
9973d83 
commit ce23f32
Author: Eirik Backer <[email protected]>
Date:   Mon Oct 28 10:31:21 2024 +0100

    fix(Chip): use input component (#2683)

    - Fixes #2669
    - Fixes wrong height implemented (now correctly `32px`)
    - Implements simplified states after dialogue with Marianne
    - Fixes better alignment of label vs. radio/checkbox
    - Implements logic so elements with the `ds-focus--visible` class
    automatically hides focus ring on children (no need for confusing,
    nested focus rings)

commit d5e0ba1
Author: Lasse Febakke Straum <[email protected]>
Date:   Fri Oct 25 15:08:14 2024 +0200

    refactor(tokens): changed spacing and sizing type to dimension (#2688)

    Co-authored-by: Tobias Barsnes <[email protected]>
    Co-authored-by: Michael Marszalek <[email protected]>

commit 6c1f99d
Author: Eirik Backer <[email protected]>
Date:   Fri Oct 25 13:52:51 2024 +0200

    chore: remove tmp field styling in testing story (#2687)

    - Since field styling is now merged, `testing.stories.tsx` no longer
    needs to fake it

commit f4f76d3
Author: Eirik Backer <[email protected]>
Date:   Fri Oct 25 13:41:36 2024 +0200

    fix(Heading+Label+ValidationMessage): clean up css styles (#2677)

    Figma task is added as #2676

commit d2fc6b9
Author: Tobias Barsnes <[email protected]>
Date:   Fri Oct 25 13:16:17 2024 +0200

    feat: rename `size` prop to `data-size` (#2680)

    resolves #2673

commit acef771
Author: Eirik Backer <[email protected]>
Date:   Fri Oct 25 10:24:19 2024 +0200

    fix(Input): inherit line-height (#2685)

    As pointed out by hawk-eye @mimarz 💪 🙏 🦅
    https://designsystemet.slack.com/archives/C07K7NEKXEW/p1729843841118129

commit d3c58b0
Author: Eirik Backer <[email protected]>
Date:   Fri Oct 25 10:04:16 2024 +0200

    fix(Spinner): use forwardRef and aria-label for consistency (#2682)

    - Use `aria-label` for accessible spinner label to be consistent with
    other components
    - Use `forwardRef` on Spinner

    ---------

    Co-authored-by: Tobias Barsnes <[email protected]>

commit 326671a
Author: Une Sofie Kinn Ekroll <[email protected]>
Date:   Fri Oct 25 08:26:49 2024 +0200

    feat(tokens): add modes for semantic color categories main & support (#2643)

    Co-authored-by: Lasse Febakke Straum <[email protected]>

commit 7520547
Author: Eirik Backer <[email protected]>
Date:   Thu Oct 24 14:19:33 2024 +0200

    fix(Radio+Checkbox): use input component (#2607)

    - Part of #2311
    - Fieldset at compound components moved to task #2666
    - Fixes #2459

commit f96289a
Author: Tobias Barsnes <[email protected]>
Date:   Thu Oct 24 11:17:42 2024 +0200

    chore: enable `noUnusedImports` biome rule (#2675)

    enables https://biomejs.dev/linter/rules/no-unused-imports/

commit a452813
Author: Une Sofie Kinn Ekroll <[email protected]>
Date:   Thu Oct 24 10:38:59 2024 +0200

    feat(cli,theme): don't output underlying primitives for semantic color variables (#2641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working css @digdir/designsystemet-css
Projects
Team Design System
Status: ✅ Done
Milestone
Helhetlig komponentbibliotek
Development

Successfully merging a pull request may close this issue.

fix(Radio+Checkbox): use input component digdir/designsystemet
2 participants
@eirikbacker @mimarz