Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a colors script in our cli #1886

Closed
mimarz opened this issue Apr 26, 2024 · 3 comments
Closed

Introduce a colors script in our cli #1886

mimarz opened this issue Apr 26, 2024 · 3 comments
Labels
cli @digdir/designsystemet

Comments

@mimarz
Copy link
Collaborator

mimarz commented Apr 26, 2024

With our new token structure we have the feature of auto-generating color scales for accent color.

We want to add the logic for generating the color scales in the cli so we can re-use it several places such as figma plugins, websites or just as pure cli script.

The color function should have names props for each color definition. When exposed through the cli, the color set could be a comma separated string.

For example npx @digdir/designsystemet add-theme Altinn --colors "#0062BA, #1E2B3C, ##F45F63, #E5AA20, #1E98F5"

@mimarz mimarz converted this from a draft issue Apr 26, 2024
@mimarz mimarz added the ⚙️ technical Technical improvements, maintenance or other issues that are not directly linked to a feature label Apr 26, 2024
@mrosvik mrosvik added this to the 4. Lansere versjon 1.0.0 milestone Apr 26, 2024
@mrosvik mrosvik moved this from 🔵 Inbox to 📄 Todo in Team Design System Apr 26, 2024
@mrosvik mrosvik removed this from the 4. Lansere versjon 1.0.0 milestone May 14, 2024
@mimarz mimarz moved this from 📄 Todo to 📋 Backlog in Team Design System May 21, 2024
@mrosvik
Copy link
Member

mrosvik commented Jun 3, 2024

Duplicate of #2085

@mrosvik mrosvik marked this as a duplicate of #2085 Jun 3, 2024
@mrosvik mrosvik closed this as completed Jun 3, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Team Design System Jun 3, 2024
@mimarz mimarz reopened this Jun 5, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🔵 Inbox in Team Design System Jun 5, 2024
@mimarz
Copy link
Collaborator Author

mimarz commented Jun 5, 2024

Re-opened as @Thuneer is going to move the logic for colors to cli/src/colors and this will be part of #2085

@mimarz mimarz moved this from 🔵 Inbox to 📄 Todo in Team Design System Jun 5, 2024
@mimarz mimarz added this to the V1 milestone Jun 5, 2024
@mimarz mimarz changed the title Introduce a "colors" script in our cli Introduce a colors script in our cli Jun 5, 2024
@mimarz mimarz added cli @digdir/designsystemet and removed ⚙️ technical Technical improvements, maintenance or other issues that are not directly linked to a feature labels Jun 5, 2024
@mrosvik mrosvik removed this from the V1 milestone Jun 25, 2024
@mrosvik mrosvik added this to the V1 - Helhetlig tematisering milestone Sep 19, 2024
@mimarz
Copy link
Collaborator Author

mimarz commented Sep 19, 2024

This was solved by #2290

@mimarz mimarz closed this as completed Sep 19, 2024
@github-project-automation github-project-automation bot moved this from 📄 Todo to ✅ Done in Team Design System Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli @digdir/designsystemet
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants