Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Component Library #1045

Closed
9 tasks done
mimarz opened this issue Nov 3, 2023 · 3 comments
Closed
9 tasks done

CSS Component Library #1045

mimarz opened this issue Nov 3, 2023 · 3 comments
Labels
☂️ epic Issues ready 🧭 roadmap Used in roadmap

Comments

@mimarz
Copy link
Collaborator

mimarz commented Nov 3, 2023

In the future want to provide our components and utilities as pure css classes for people to use with plain html or other technologies.

Suggested package name: @digdir/designsystemet-css

Notes

Tasks

Preview Give feedback
  1. 33 of 33
    css react
    Barsnes mimarz
    poi33
  2. 0 of 5
  3. 38 of 38
    css ☂️ epic
  4. css react 🕵️ investigate
    eirikbacker
  5. css
    eirikbacker
  6. css
  7. 15 of 16
    css react ☂️ epic
  8. 6 of 6
    ☂️ epic 🕵️ investigate
    Febakke
  9. css
    Barsnes
@mimarz mimarz converted this from a draft issue Nov 3, 2023
@mimarz mimarz changed the title CSS package CSS library Nov 3, 2023
@mimarz mimarz added ☂️ epic Issues ready 🧭 roadmap Used in roadmap labels Nov 8, 2023
@mimarz mimarz moved this from 📋 Backlog to Epics in Team Design System Nov 8, 2023
@mrosvik mrosvik changed the title CSS library CSS Component Library Apr 11, 2024
@mrosvik mrosvik changed the title CSS Component Library Component Library Sep 27, 2024
@mimarz mimarz changed the title Component Library CSS Component Library Oct 15, 2024
@Barsnes
Copy link
Member

Barsnes commented Jan 16, 2025

We need to ensure our selectors work in a consisten way.
Sometimes the DOM does not need to follow explicit rules. Tabs, for example, can have a wrapper around the panels.
Our current selectors would break this.

A suggestion from @eirikbacker is to run selectors like

& [role="tabpanel"]:not([role="tabpanel"] [role="tabpanel"])

However, places where we want the consumers to keep a specific DOM structure, we should use CSS in a way that would "break" doing other DOM setups.

@eirikbacker
Copy link
Contributor

yeah, and we need to test this selector - does it work if using .tabs inside .tabs, because that would actually meet [role="tabpanel"] [role="tabpanel"] as well 🤔

@mrosvik
Copy link
Member

mrosvik commented Jan 22, 2025

Closing this as we have completed the first version. Further enhancements will be addressed in separate issues.

@mrosvik mrosvik closed this as completed Jan 22, 2025
@github-project-automation github-project-automation bot moved this from ☂ Todo Epics to ✅ Done in Team Design System Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ epic Issues ready 🧭 roadmap Used in roadmap
Projects
Status: Under arbeid
Status: ✅ Done
Development

No branches or pull requests

4 participants