Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable if data-method exists and is not GET #170

Open
david-a-wheeler opened this issue Aug 28, 2019 · 0 comments
Open

Disable if data-method exists and is not GET #170

david-a-wheeler opened this issue Aug 28, 2019 · 0 comments

Comments

@david-a-wheeler
Copy link

david-a-wheeler commented Aug 28, 2019 •
edited
Loading

Rails is a popular framework and supports an optional "data-method" parameter, like this:

<a rel="nofollow" data-method="delete" href="/en/logout">

It would be very bad to automatically follow such links if data-method exists and is not GET.

Solution: Simply don't preload a links that have a data-method and provide a value other than GET (any case).

See also: instantpage/instant.page#47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@david-a-wheeler