Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on inventory <> liquidity #59

Open
sunmilee opened this issue Mar 2, 2021 · 0 comments
Open

Documentation on inventory <> liquidity #59

sunmilee opened this issue Mar 2, 2021 · 0 comments
Assignees

Comments

@sunmilee
Copy link
Contributor

sunmilee commented Mar 2, 2021

Would love to see more detailed documentation on how the interaction between inventory logic and liquidity emulator works. For example, having more inline documentation in https://github.com/diem/reference-wallet/blob/master/backend/wallet/services/inventory.py would be helpful.

Another example is when I asked how subaddressing works for inventory account in DRW. Yaniv's response was super helpful, and it would be good to write it as code comment as well: "Each time the wallet asks for funds from the liquidity service, it generates a new subaddress for the inventory account. In general, each account (i.e. each user) can have infinite associated sub-addresses (so Account table and SubAddress table have one-to-many relationship). This is a common behavior for blockchain wallets. This is how wallets avoid privacy issues, given all the data on the blockchain is public."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants