Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can init be combined with binseg? #19

Open
tdhock opened this issue Aug 24, 2021 · 1 comment
Open

can init be combined with binseg? #19

tdhock opened this issue Aug 24, 2021 · 1 comment

Comments

@tdhock
Copy link

tdhock commented Aug 24, 2021

hi @diego-urgell looking at RcppInterface.cpp I see

    algo -> init(&data[0], data.size(), numCpts, dist, minSegLen, &params_mat[0]);
    algo -> binseg();

Is there any reason you would run init without binseg (or vice versa) ? If so can you maybe add a comment to explain/clarify? If not can you please combine them to avoid confusion?

@diego-urgell
Copy link
Owner

I completely agree with you. I think it would be possible to move the init call into the binseg method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants