-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Update wallet credentials docstrings #814
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cl0ete
changed the title
WIP: update wallet credentials docstrings
Update wallet credentials docstrings
May 24, 2024
Coverage Report
|
ff137
requested changes
Jun 7, 2024
ff137
reviewed
Jun 11, 2024
Quality Gate passedIssues Measures |
K8s Test Coverage
|
K8s Regression Test Coverage
|
cl0ete
force-pushed
the
swagger-update-wallet-creds
branch
from
July 15, 2024 12:58
eb724ff
to
7d59f0b
Compare
Quality Gate passedIssues Measures |
cl0ete
force-pushed
the
swagger-update-wallet-creds
branch
from
October 29, 2024 12:31
6969871
to
c85e74f
Compare
K8s Test Coverage
|
K8s Regression Test Coverage
|
ff137
approved these changes
Nov 4, 2024
Quality Gate passedIssues Measures |
K8s Test Coverage
|
K8s Regression Test Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
wallet/credentails
docstringsUpdate route to list
w3c
credentials. It classes with.../credentials/{credential_id}
Extend models to have a
credential_id
fieldChanges:
GET /v1/wallet/credentials
no longer takes stringcount
/start
params - renamed tolimit
/offset
with integer typeGET /w3c
changed toGET /list/w3c
(to be reverted: shouldn't have been changed)record_id
in VCrecord andreferent
in IndyCredInfo are deprecated; replaced withcredential_id