-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix endorser Nats connection going stale #1122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K8s Regression Test Coverage
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
K8s Test Coverage
|
K8s Regression Test Coverage
|
cl0ete
force-pushed
the
wait-issuer-did-endorse
branch
2 times, most recently
from
October 16, 2024 14:49
4025fa2
to
29ed1b4
Compare
cl0ete
changed the title
Wait issuer did endorse
Fix endorser Nats connection going stale
Oct 17, 2024
cl0ete
changed the title
Fix endorser Nats connection going stale
🐛 Fix endorser Nats connection going stale
Oct 17, 2024
ff137
approved these changes
Oct 17, 2024
…ections protocol (#1119) * 🗑️ mark deprecated routes * 🚧 initial implementation of new did-exchange routes * 🎨 modify default extra settings example * 🔧 Update default pylint config * 🎨 update docstrings and available optional params * 🚧 e2e test under construction * ✅ fix up create request tests * 🐛 fix protocol: /1.1 doesn't work ... * 🐛 use_public_did must be false in accept-request * ✅ working tests for accept-request * 🎨 remove unused endpoint and update route names * 🎨 update route names * 🎨 accept reject reason sa body instead of param * ⬆️ Use latest cloudcontroller * ⬆️ Update lock files * ✨ implement did-rotate endpoints * 🔧 add max-positional-arguments to pylintrc * ⬆️ use latest cloudcontroller * ⬆️ Update lock files * ✨ Use did-rotate/hangup in deletion of connection record (if using didexchange protocol) * ✅ Fix deleting records when using oob connections * ✅ assert connections are complete for both parties * ✅ e2e tests for did-rotate * ⬆️ Helmfile `0.169`, Helm `3.16.2`, Tailscale `1.76.0` (#1123) * 📌 Pin `xk6` and plugin versions (#1124) * `xk6-sse` isn't compatible with `k6>=0.53` * Pin `xk6` and all plugins to the latest compatible versions * Also bump Golang to `1.23` * 📌 Explicitly pin k6 to `v0.52.0` (#1125) * ⬆️ Update lock files * 🎨 * ✅ 100% unit test coverage for new did-exchange and did-rotate methods * ✅ fixed up delete connection test * 🐛 Reconfigure ACAPY_AUTO_ACCEPT_REQUESTS for Faber after test completes * ✅ add cleaning up of connection records, for regression fixtures not to get bloated --------- Co-authored-by: Robbie Blaine <[email protected]>
ff137
force-pushed
the
wait-issuer-did-endorse
branch
from
October 17, 2024 15:19
a9722d5
to
1e66728
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add heartbeat to fetch from NATS, this gives error to catch so that we can re-subscribe.
Updated endorser health endpoints and add tests.
Closes #1120