Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't listen for post_delete on all models. #1

Open
sleepyjames opened this issue Mar 10, 2011 · 1 comment
Open

Don't listen for post_delete on all models. #1

sleepyjames opened this issue Mar 10, 2011 · 1 comment

Comments

@sleepyjames
Copy link

Currently favourites registers to receive post_delete signal for all models. This should be configurable to allow you to only register for the models used. eg:

FAVOURITE_REGISTER_CLEANUP_FOR = ('foo_app.BarModel', 'bar_app.FooModel')

or something similar.

Or alternatively use a register pattern to register the models you want to use with favourites in the first place eg.

favourites.register(Foo)

This would add only allow a user to favour objects of class Foo and register to cleanup on Foo's post_delete

@dhilton
Copy link
Owner

dhilton commented Mar 10, 2011

Good idea on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants