Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tomato-biologic: Update driver to work with new DriverInterface #70

Open
3 tasks
PeterKraus opened this issue Mar 5, 2024 · 4 comments
Open
3 tasks
Labels

Comments

@PeterKraus
Copy link
Contributor

This should probably be done in 3 steps:

  • move kbio to a separate package which will be an optional dependency
  • rewrite the biologic driver, perhaps implementing command batching
  • test, test, test

Tagging @NukP and @edan-bainglass.

@PeterKraus PeterKraus added this to the 1.0 milestone Jul 17, 2024
@PeterKraus PeterKraus changed the title biologic: Update driver to work with new framework tomato-biologic: Update driver to work with new DriverInterface Jul 17, 2024
@PeterKraus
Copy link
Contributor Author

Following yesterday's dicussion, @g-kimbell has been volunteered to give this one a shot.

In the first instance, let's try to get a basic driver working (maybe even just the basic methods), and then punt implementing things like task batching into the future.

@g-kimbell
Copy link

I will start working on this in September when I should be able to free up an MPG2 cycler for testing

@NukP
Copy link

NukP commented Jul 17, 2024

Same as @g-kimbell I will probably have more time to work on this in September.

@PeterKraus
Copy link
Contributor Author

No longer a tomato-1.0 milestone, since the drivers are separately versioned anyway.

@PeterKraus PeterKraus removed this from the 1.0 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants