Skip to content

Latest commit

 

History

History
81 lines (58 loc) · 3.1 KB

CONTRIBUTING.md

File metadata and controls

81 lines (58 loc) · 3.1 KB
Raw

Spree Paypal Express is an open source project and we encourage contributions. Please see the contributors guidelines before contributing.

Filing an issue

When filing an issue on this extension, please first do these things:

  • Verify you can reproduce this issue in a brand new application.
  • Include the httplog in that application's Gemfile.
  • Run through the steps to reproduce the issue again.
  • Create a Gist which contains the complete output from the server during the course of these transactions.

This information will help us replicate what's going wrong on the PayPal side of things.

In the issue itself please provide:

  • A comprehensive list of steps to reproduce the issue.
  • What you're expecting to happen compared with what's actually happening.
  • The version of Spree and the version of Rails.
  • A list of all extensions.
  • Any relevant stack traces ("Full trace" preferred)
  • Your Gemfile

In 99% of cases, this information is enough to determine the cause and solution to the problem that is being described.

Please remember to format code using triple backticks (`) so that it is neatly formatted when the issue is posted.

Any issue that is open for 14 days without actionable information or activity will be marked as "stalled" and then closed. Stalled issues can be re-opened if the information requested is provided.

Pull requests

We gladly accept pull requests to fix bugs and, in some circumstances, add new features to this extension.

Here's a quick guide:

  1. Fork the repo.

  2. Run the tests. We only take pull requests with passing tests, and it's great to know that you have a clean slate:

     $ bash build.sh

  3. Create new branch then make changes and add tests for your changes. Only refactoring and documentation changes require no new tests. If you are adding functionality or fixing a bug, we need tests!

  4. Push to your fork and submit a pull request. If the changes will apply cleanly to the latest stable branches and master branch, you will only need to submit one pull request.

At this point you're waiting on us. We like to at least comment on, if not accept, pull requests within three business days (and, typically, one business day). We may suggest some changes or improvements or alternatives.

Some things that will increase the chance that your pull request is accepted, taken straight from the Ruby on Rails guide:

  • Use Rails idioms and helpers
  • Include tests that fail without your code, and pass with it
  • Update the documentation, the surrounding one, examples elsewhere, guides, whatever is affected by your contribution

Syntax:

  • Two spaces, no tabs.
  • No trailing whitespace. Blank lines should not have any space.
  • Prefer &&/|| over and/or.
  • MyClass.my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
  • a = b and not a=b.
  • a_method { |block| ... } and not a_method { | block | ... }
  • Follow the conventions you see used in the source already.
  • -> symbol over lambda
  • Ruby 1.9 hash syntax over Ruby 1.8 hash syntax

And in case we didn't emphasize it enough: we love tests!