diff --git a/CHANGELOG.md b/CHANGELOG.md index e41c99e..119d6b3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,10 @@ ### Pending Release +### v1.2.0 + +- :rocket: Add SG Names to policy + ### v1.1.0 - :rocket: Update to latest alarms package which makes topic conditional diff --git a/cloudformation/lib/api.js b/cloudformation/lib/api.js index dfe9a47..4563a24 100644 --- a/cloudformation/lib/api.js +++ b/cloudformation/lib/api.js @@ -283,7 +283,12 @@ export default { ServiceSecurityGroup: { Type: 'AWS::EC2::SecurityGroup', Properties: { - GroupDescription: cf.join('-', [cf.stackName, 'ec2-sg']), + Tags: [{ + Key: 'Name', + Value: cf.join('-', [cf.stackName, 'ecs-service-sg']) + }], + GroupName: cf.join('-', [cf.stackName, 'ecs-service-sg']), + GroupDescription: cf.join('-', [cf.stackName, 'ecs-sg']), VpcId: cf.importValue(cf.join(['coe-vpc-', cf.ref('Environment'), '-vpc'])), SecurityGroupIngress: [{ CidrIp: '0.0.0.0/0', diff --git a/cloudformation/lib/efs.js b/cloudformation/lib/efs.js index fac6d0e..efed774 100644 --- a/cloudformation/lib/efs.js +++ b/cloudformation/lib/efs.js @@ -16,14 +16,19 @@ export default { EFSMountTargetSecurityGroup: { Type: 'AWS::EC2::SecurityGroup', Properties: { - VpcId: cf.importValue(cf.join(['coe-vpc-', cf.ref('Environment'), '-vpc'])), + Tags: [{ + Key: 'Name', + Value: cf.join('-', [cf.stackName, 'efs-sg']) + }], + GroupName: cf.join('-', [cf.stackName, 'efs-sg']), GroupDescription: 'EFS to Auth ECS Service', SecurityGroupIngress: [{ IpProtocol: 'tcp', FromPort: 2049, ToPort: 2049, CidrIp: cf.importValue(cf.join(['coe-vpc-', cf.ref('Environment'), '-vpc-cidr'])) - }] + }], + VpcId: cf.importValue(cf.join(['coe-vpc-', cf.ref('Environment'), '-vpc'])), } }, EFSAccessPointLDAP: {