From d348bc3d86a07bd080465348aa93bd2b70ee9e7a Mon Sep 17 00:00:00 2001 From: Eric Swanson Date: Tue, 19 Sep 2023 14:47:13 -0700 Subject: [PATCH 1/2] fix: remove project-specific network deprecation warning --- CHANGELOG.md | 4 ++++ src/dfx-core/src/network/provider.rs | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 74cea9f8d6..a9837c5bf9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -61,6 +61,10 @@ If `dfx start` is starting the shared network from within a dfx project, and tha The parameter was erroneously passed twice. Now it is passed only once. +### fix: Removed deprecation warning about project-specific networks + +Removed this warning: "Project-specific networks are deprecated and will be removed after February 2023." While we may remove project-specific networks in the future, it is not imminent. One key requirement is the ability to run more than one subnet type at one time. + ## Dependencies ### Frontend canister diff --git a/src/dfx-core/src/network/provider.rs b/src/dfx-core/src/network/provider.rs index 4f383c468a..7615de99b2 100644 --- a/src/dfx-core/src/network/provider.rs +++ b/src/dfx-core/src/network/provider.rs @@ -353,10 +353,6 @@ fn create_project_network_descriptor( network_name, config.get_path().display(), ); - warn!( - logger, - "Project-specific networks are deprecated and will be removed after February 2023." - ); let data_directory = config.get_temp_path().join("network").join(network_name); let legacy_pid_path = Some(config.get_temp_path().join("pid")); From 90e6bd492f72b50333b07c9dbbff279b3c319b3c Mon Sep 17 00:00:00 2001 From: Eric Swanson Date: Tue, 19 Sep 2023 14:54:27 -0700 Subject: [PATCH 2/2] docs --- docs/cli-reference/dfx-start.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/cli-reference/dfx-start.md b/docs/cli-reference/dfx-start.md index ed8875deaa..83a399d66c 100644 --- a/docs/cli-reference/dfx-start.md +++ b/docs/cli-reference/dfx-start.md @@ -84,6 +84,4 @@ dfx stores data for the shared local network in one of the following locations, If dfx.json defines the `local` network, then `dfx start` will use this definition and store network data files under `\/.dfx/network/local`. -Such project-specific networks are deprecated, and we plan to remove support for them after February 2023. We encourage you to remove any definitions of the `local` network from your project's dfx.json file and instead use the default shared local network. - Note that for projects that define the `local` network in dfx.json, you can only run the `dfx start` and `dfx stop` commands from within the project directory structure. For example, if your project name is `hello_world`, your current working directory must be the `hello_world` top-level project directory or one of its subdirectories.