From 4b36d597545a433dca8ea025ae6ee20ba5deb5d8 Mon Sep 17 00:00:00 2001
From: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
Date: Tue, 5 Dec 2023 18:52:19 -0800
Subject: [PATCH] fix: on PRs, run shellcheck for install scripts (#3469)

Runs the shellcheck workflow for the install script on PRs as well as merge to master, skipping the upload step for PRs.
For the publish-manifest workflow, sets the name to `install-script-shellcheck:required` for later inclusion as a required status.
Does not do this for the dfxvm-install-script-shellcheck, since we'd only remove it again soon, but it will still be reported as a status.
---
 .github/workflows/publish-dfxvm-install-script.yml | 3 +++
 .github/workflows/publish-manifest.yml             | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/.github/workflows/publish-dfxvm-install-script.yml b/.github/workflows/publish-dfxvm-install-script.yml
index 5ab630cdcc..14ca33c04b 100644
--- a/.github/workflows/publish-dfxvm-install-script.yml
+++ b/.github/workflows/publish-dfxvm-install-script.yml
@@ -4,6 +4,7 @@ on:
   push:
     branches:
       - sdk-1278-dfxvm-install-script
+  pull_request:
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -17,6 +18,7 @@ env:
 
 jobs:
   publish-manifest:
+    name: dfxvm-install-script-shellcheck
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -37,6 +39,7 @@ jobs:
             s/ *#.*//
           " _out/install.sh
       - name: Upload Artifacts
+        if: github.event_name == 'push'
         uses: JamesIves/github-pages-deploy-action@releases/v3
         with:
           single_commit: yes
diff --git a/.github/workflows/publish-manifest.yml b/.github/workflows/publish-manifest.yml
index a6fa2840e4..da3dea0c11 100644
--- a/.github/workflows/publish-manifest.yml
+++ b/.github/workflows/publish-manifest.yml
@@ -4,6 +4,7 @@ on:
   push:
     branches:
       - master
+  pull_request:
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -17,6 +18,7 @@ env:
 
 jobs:
   publish-manifest:
+    name: install-script-shellcheck:required
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -38,6 +40,7 @@ jobs:
           " _out/install.sh
           cp public/manifest.json _out/manifest.json
       - name: Upload Artifacts
+        if: github.event_name == 'push'
         uses: JamesIves/github-pages-deploy-action@releases/v3
         with:
           single_commit: yes