From 10ee5858ef10c47f15494c0a29fa74a083566877 Mon Sep 17 00:00:00 2001
From: Severin Siffert <severin.siffert@dfinity.org>
Date: Wed, 1 Nov 2023 11:20:18 +0100
Subject: [PATCH] reword

---
 e2e/tests-dfx/assetscanister.bash                               | 2 --
 .../ic-certified-assets/src/asset_certification/types/http.rs   | 2 +-
 src/canisters/frontend/ic-certified-assets/src/tests.rs         | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/e2e/tests-dfx/assetscanister.bash b/e2e/tests-dfx/assetscanister.bash
index 6bb6894106..628ec8ed82 100644
--- a/e2e/tests-dfx/assetscanister.bash
+++ b/e2e/tests-dfx/assetscanister.bash
@@ -1235,8 +1235,6 @@ CHERRIES" "$stdout"
 
   touch src/e2e_project_frontend/assets/thing.json
 
-  # this test used to also set etag, but that breaks certification
-  # see https://dfinity.atlassian.net/browse/SDK-1245
   echo '[
     {
       "match": "thing.json",
diff --git a/src/canisters/frontend/ic-certified-assets/src/asset_certification/types/http.rs b/src/canisters/frontend/ic-certified-assets/src/asset_certification/types/http.rs
index 69734313c0..8ca56fc6fe 100644
--- a/src/canisters/frontend/ic-certified-assets/src/asset_certification/types/http.rs
+++ b/src/canisters/frontend/ic-certified-assets/src/asset_certification/types/http.rs
@@ -184,7 +184,7 @@ impl HttpResponse {
         } else {
             if !headers
                 .iter()
-                .any(|(header, _)| header.eq_ignore_ascii_case("etag"))
+                .any(|(header_name, _)| header_name.eq_ignore_ascii_case("etag"))
             {
                 headers.insert(
                     "etag".to_string(),
diff --git a/src/canisters/frontend/ic-certified-assets/src/tests.rs b/src/canisters/frontend/ic-certified-assets/src/tests.rs
index 58505cde50..ad728e73ea 100644
--- a/src/canisters/frontend/ic-certified-assets/src/tests.rs
+++ b/src/canisters/frontend/ic-certified-assets/src/tests.rs
@@ -1879,7 +1879,7 @@ mod certification_v2 {
     #[test]
     fn etag() {
         // For now only checks that defining a custom etag doesn't break certification.
-        // Serving 304 responses if the etag matches is part of https://dfinity.atlassian.net/browse/SDK-191
+        // Serving HTTP 304 responses if the etag matches is part of https://dfinity.atlassian.net/browse/SDK-191
 
         let mut state = State::default();
         let time_now = 100_000_000_000;