Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to run dev server using TLS #1986

Closed
wants to merge 1 commit into from

Conversation

frederikrothenberger
Copy link
Contributor

@frederikrothenberger frederikrothenberger commented Oct 26, 2023

This PR introduces the env variable TLS_DEV_SERVER that can be set to 1 to enable the dev server serving content using tls.

This PR introduces the env variable `TLS_DEV_SERVER` that
can be set to `1` to enable the dev server serving content
using tls.
Copy link
Collaborator

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

suggestion: what about introducing this only when we actually use it? then you could also add a comment explaining why it's used/what it's used for

@frederikrothenberger
Copy link
Contributor Author

Superseded by #1995.

@nmattia nmattia deleted the frederik/ssl-dev-server branch November 7, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants