From 51d6b46c441e119d343870f9c861d6acd7936faf Mon Sep 17 00:00:00 2001
From: David Dal Busco <david.dalbusco@dfinity.org>
Date: Wed, 20 Nov 2024 18:23:03 +0100
Subject: [PATCH] test: improve throw error assertions (and fix one test)
 (#760)

# Motivation

I noticed that the pattern to assert functions throw errors in ic-mgmt
could be improved. While doing so, I noticed that one test was actually
asserting an error but, the root cause was due to an incorect function
mock

# Changes

- Use ` await expect(call).rejects.toThrow(error);` to assert for errors
- i.e. assert the error is the one mocked
- Fix mock for `provisional_create_canister_with_cycles` error assertion
which was mockding `delete_canister` (I guess copy/paste error)

Signed-off-by: David Dal Busco <david.dalbusco@dfinity.org>
---
 .../src/ic-management.canister.spec.ts        | 30 +++++++++----------
 1 file changed, 15 insertions(+), 15 deletions(-)

diff --git a/packages/ic-management/src/ic-management.canister.spec.ts b/packages/ic-management/src/ic-management.canister.spec.ts
index 55b48bda3..41079e646 100644
--- a/packages/ic-management/src/ic-management.canister.spec.ts
+++ b/packages/ic-management/src/ic-management.canister.spec.ts
@@ -71,7 +71,7 @@ describe("ICManagementCanister", () => {
 
       const call = () => icManagement.createCanister();
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -201,7 +201,7 @@ describe("ICManagementCanister", () => {
           settings: mockCanisterSettings,
         });
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -247,7 +247,7 @@ describe("ICManagementCanister", () => {
 
       const call = () => icManagement.installCode(params);
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -276,7 +276,7 @@ describe("ICManagementCanister", () => {
       const call = () =>
         icManagement.uninstallCode({ canisterId: mockCanisterId });
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -303,7 +303,7 @@ describe("ICManagementCanister", () => {
 
       const call = () => icManagement.startCanister(mockCanisterId);
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -330,7 +330,7 @@ describe("ICManagementCanister", () => {
 
       const call = () => icManagement.stopCanister(mockCanisterId);
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -379,7 +379,7 @@ describe("ICManagementCanister", () => {
 
       const call = () => icManagement.canisterStatus(mockCanisterId);
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -406,7 +406,7 @@ describe("ICManagementCanister", () => {
 
       const call = () => icManagement.deleteCanister(mockCanisterId);
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -444,13 +444,13 @@ describe("ICManagementCanister", () => {
     it("throws Error", async () => {
       const error = new Error("Test");
       const service = mock<IcManagementService>();
-      service.delete_canister.mockRejectedValue(error);
+      service.provisional_create_canister_with_cycles.mockRejectedValue(error);
 
       const icManagement = await createICManagement(service);
 
       const call = () => icManagement.provisionalCreateCanisterWithCycles();
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -487,7 +487,7 @@ describe("ICManagementCanister", () => {
 
       const call = () => icManagement.uploadChunk(params);
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -518,7 +518,7 @@ describe("ICManagementCanister", () => {
 
       const call = () => icManagement.clearChunkStore(params);
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -556,7 +556,7 @@ describe("ICManagementCanister", () => {
 
       const call = () => icManagement.storedChunks(params);
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -667,7 +667,7 @@ describe("ICManagementCanister", () => {
 
       const call = () => icManagement.installChunkedCode(params);
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 
@@ -715,7 +715,7 @@ describe("ICManagementCanister", () => {
 
       const call = () => icManagement.fetchCanisterLogs(mockCanisterId);
 
-      expect(call).rejects.toThrowError(Error);
+      await expect(call).rejects.toThrow(error);
     });
   });
 });