Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of tweetnacl is breaking the build 🚨 #15

Open
greenkeeper bot opened this issue Jan 16, 2020 · 2 comments
Open

An in-range update of tweetnacl is breaking the build 🚨 #15

greenkeeper bot opened this issue Jan 16, 2020 · 2 comments

Comments

@greenkeeper
Copy link

greenkeeper bot commented Jan 16, 2020

The dependency tweetnacl was updated from 1.0.1 to 1.0.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

tweetnacl is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Author

greenkeeper bot commented Jan 16, 2020

After pinning to 1.0.1 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@greenkeeper
Copy link
Author

greenkeeper bot commented Feb 10, 2020

  • The dependency tweetnacl was updated from 1.0.2 to 1.0.3.

Your tests are still failing with this version. Compare changes

Release Notes for Important security fix

IMPORTANT BUG FIX. Due to a bug in calculating carry in
modulo reduction that used bit operations on integers larger than
32 bits, nacl.sign or nacl.sign.detached could have created
incorrect signatures.

This only affects signing, not verification.

Thanks to @valerini on GitHub for finding and reporting the bug.

Commits

The new version differs by 4 commits.

See the full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants