Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requiring jsoneditor instead of manual import #7

Open
mebibou opened this issue Nov 29, 2018 · 0 comments
Open

Requiring jsoneditor instead of manual import #7

mebibou opened this issue Nov 29, 2018 · 0 comments

Comments

@mebibou
Copy link

mebibou commented Nov 29, 2018

I believe it would be a lot easier if you used in the component:

import { JSONEditor } from 'jsoneditor';

and also users could get the styles from

@import "~jsoneditor/dist/jsoneditor.min.css";

This would work by adding jsoneditor as a dependency. Including the libraries from the CDN is not really the angular/npm way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant