Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute flake8 with fiasko_bro #75

Open
Melevir opened this issue Feb 15, 2018 · 2 comments
Open

Execute flake8 with fiasko_bro #75

Melevir opened this issue Feb 15, 2018 · 2 comments
Assignees
Milestone

Comments

@Melevir
Copy link
Contributor

Melevir commented Feb 15, 2018

if VALIDATOR_SETTINGS['is_user_flake8'] == True (default is true), then execute flake8 validation on path with path to setup.cfg if exists.
Errors from flake8 should be if form of ('flake8: E221', 'for example, ...') (error type with prefix and no comment) and should be grouped per error type (one line per error).

@Melevir Melevir added this to the 0.0.2 milestone Feb 15, 2018
@Melevir Melevir changed the title Execute pycoderstyle with fiasko_bro Execute flake8 with fiasko_bro Feb 20, 2018
@vergeev
Copy link
Contributor

vergeev commented Mar 31, 2018

I think I'm going to use flake's Python API. But: Flake8 3.0.0 presently does not have a public, stable Python API. according to this.

More specificly, I'm trying to make use of the legacy API.

@vergeev
Copy link
Contributor

vergeev commented Apr 3, 2018

As I described in the Slack chat, this may not be possible to accomplish in a clean way.

It seems to me our choices are:

  • use internal classes and methods of flake8 in order to retrieve the information we need;
  • run flake8 with something like fabric and parse the output.

Since I don't like either of those, I am proposing to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants