Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare error messages when counting commits #115

Open
vergeev opened this issue Apr 19, 2018 · 0 comments
Open

Compare error messages when counting commits #115

vergeev opened this issue Apr 19, 2018 · 0 comments

Comments

@vergeev
Copy link
Contributor

vergeev commented Apr 19, 2018

Right now, the validator has_more_commits_than_origin has the following FIXME:

# FIXME this check works incorrectly in case of
# new commit in original repo after student forked it

I suggest comparing the contents of the commit messages as well as the number of them. GitPython allows us to access the commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant