misc: Address comments

devito/types/array.py

@@ -20,8 +20,11 @@ class ArrayBasic(AbstractFunction, LocalType):
     __rkwargs__ = AbstractFunction.__rkwargs__ + ('is_const', 'liveness')
 
     def __init_finalize__(self, *args, **kwargs):
-        self._liveness = kwargs.setdefault('liveness', 'lazy')
         super().__init_finalize__(*args, **kwargs)
+
+        self._liveness = kwargs.get('liveness', 'lazy')
+        assert self._liveness in ['eager', 'lazy']
+
         self._is_const = kwargs.get('is_const', False)
 
     @classmethod
@@ -112,8 +115,8 @@ class Array(ArrayBasic):
 
     is_Array = True
 
-    __rkwargs__ = (AbstractFunction.__rkwargs__ +
-                   ('dimensions', 'liveness', 'scope', 'initvalue'))
+    __rkwargs__ = (ArrayBasic.__rkwargs__ +
+                   ('dimensions', 'scope', 'initvalue'))
 
     def __new__(cls, *args, **kwargs):
         kwargs.update({'options': {'evaluate': False}})
@@ -127,9 +130,6 @@ def __new__(cls, *args, **kwargs):
     def __init_finalize__(self, *args, **kwargs):
         super().__init_finalize__(*args, **kwargs)
 
-        self._liveness = kwargs.get('liveness', 'lazy')
-        assert self._liveness in ['eager', 'lazy']
-
         self._scope = kwargs.get('scope', 'heap')
         assert self._scope in ['heap', 'stack', 'static', 'constant', 'shared']
 

devito/types/basic.py

@@ -1672,7 +1672,7 @@ class LocalType(Basic):
 
     Notes
     -----
-    Subclasses should setup `liveness`.
+    Subclasses should setup `_liveness`.
     """
 
     is_LocalType = True
@@ -1689,4 +1689,9 @@ def _mem_internal_eager(self):
     def _mem_internal_lazy(self):
         return self._liveness == 'lazy'
 
+    """
+    A modifier added to the subclass C declaration when it appears
+    in a function signature. For example, a subclass might define `_C_modifier = '&'`
+    to impose pass-by-reference semantics.
+    """
     _C_modifier = None

devito/types/object.py

@@ -231,12 +231,6 @@ def _C_free(self):
         """
         return None
 
-    """
-    A modifier added to the LocalObject's C declaration when the object appears
-    in a function signature. For example, a subclass might define `_C_modifier = '&'`
-    to impose pass-by-reference semantics.
-    """
-
     @property
     def _mem_global(self):
         return self._is_global