Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: memcached (original) #2273

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

inpour
Copy link

@inpour inpour commented Sep 22, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #2271

Link to prove your SVG is correct and up-to-date.

https://memcached.org/

Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to devicons 👍

I've left some comments on how to improve the MR. If you have any questions or need help feel free to ask!

"original"
],
"font": [
"original"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original SVG contains multiple paths and colors. Please create a plain.svg icon that follows our SVG guidelines and use that new icon for the font version,

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the SVG! There are just a few adjustments needed:

  1. The SVG needs to be optimized. Please follow this tutorial for guidance.
  2. Since the icon contains multiple paths and colors, it can't be used as the font version. Please create a plain.svg version with a single path and color.

@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants