Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add swiper (original) #1922

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Add swiper (original) #1922

merged 6 commits into from
Oct 24, 2023

Conversation

Gautam25Raj
Copy link
Contributor

@Gautam25Raj Gautam25Raj commented Oct 22, 2023 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1836

Link to prove your SVG is correct and up-to-date.

Swiper Official Link: https://swiperjs.com

Snailedlt
Snailedlt requested changes Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, some minor suggestions and we're good to go!
Oh, no biggie, but for legacy editor support we recommend adding a newline (an empty line) at the end of all .svg files

devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
Gautam25Raj and others added 3 commits October 23, 2023 16:30
@Gautam25Raj @Snailedlt
Update devicon.json
8533eec 
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@Gautam25Raj @Snailedlt
Update devicon.json
4942894 
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@Gautam25Raj
Update swiper-original.svg
b1ee3b3
Gautam25Raj
Gautam25Raj commented Oct 23, 2023
View reviewed changes
Copy link
Contributor Author

@Gautam25Raj Gautam25Raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everything looks fine.

@Gautam25Raj Gautam25Raj requested a review from Snailedlt October 23, 2023 11:05
weh
weh approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weh weh added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 24, 2023
@weh weh requested review from a team, ConX, canaleal and lunatic-fox and removed request for a team October 24, 2023 08:51
Snailedlt
Snailedlt approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Thank you for another great contribution! 💯 🙇

@Snailedlt Snailedlt merged commit 34bfcc2 into devicons:develop Oct 24, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snailedlt Snailedlt Snailedlt approved these changes

@weh weh weh approved these changes

@ConX ConX Awaiting requested review from ConX

@canaleal canaleal Awaiting requested review from canaleal

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gautam25Raj @weh @Snailedlt