Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: jetpackcompose (original, original-wordmark,plain,plain-wordmark,line,line-wordmark) #1839

Merged
merged 18 commits into from
Oct 24, 2023

Conversation

sameemul-haque
Copy link
Contributor

@sameemul-haque sameemul-haque commented Jul 23, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #1067

Link to prove your SVG is correct and up-to-date.

@sameemul-haque sameemul-haque changed the title new icon: jetpackcompose (original, original-wordmark) new icon: jetpackcompose (original, original-wordmark,plain,plain-wordmark,line,line-wordmark) Jul 24, 2023
@Panquesito7 Panquesito7 added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Jul 25, 2023
devicon.json Outdated Show resolved Hide resolved
devicon.json Outdated Show resolved Hide resolved
Co-authored-by: David Leal <[email protected]>
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sameemul-haque, great work on this PR, and making icons for all the different versions!
Overall the PR is good, but I've suggested some changes for you.

Other than the suggested change, here are some more things that need to be fixed before this PR can be accepted:

  1. line and plain versions should have unified paths. See SVG-Versions for more info
  2. The icons need to be centered and have as little padding as possible. i.e. they should fill the whole viewbox. For more info see SVG-Standards

devicon.json Outdated Show resolved Hide resolved
sameemul-haque and others added 2 commits October 21, 2023 22:24
Co-authored-by: Jørgen Kalsnes Hagen <[email protected]>
@sameemul-haque
Copy link
Contributor Author

Hello @Snailedlt, I have updated the icons a863139. Could you please review them when you have some free time? Thank you.

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one issue left as far as I can see now :)

Also a preference thing, but I feel like the entire plain icon should be filled so that it looks something like this rough sketch:
jetpackcompose-plain-example

icons/jetpackcompose/jetpackcompose-line-wordmark.svg Outdated Show resolved Hide resolved
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!
Imo the plain version still look a bit off though. Again, a preference thong so feel to disagree with me.
What I mean is that it looks like a slightly different logo than the line and original versions since the lines are not the same thickness, and don't have the same positions. Ideally the see-through lines on the plain version should be as thin as the lines on the line version. So you can almost think of it as an inverted line version if that makes sense.
I tried to point at the most obvious difference here:
Screenshot_20231022_114456

@sameemul-haque
Copy link
Contributor Author

Is this alright? If you have any other suggestions, please feel free to share, and I'll make the necessary changes accordingly.

image

@Snailedlt
Copy link
Collaborator

Is this alright? If you have any other suggestions, please feel free to share, and I'll make the necessary changes accordingly.

image

Yes that looks exactly like I imagined it! Great work!

Snailedlt
Snailedlt previously approved these changes Oct 22, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this PR turned out really good in the end! 🥇
Thank you for your awesome contribution! Hope to see you contribute again! 🙇‍♂️

@Snailedlt Snailedlt requested review from a team, ConX and weh and removed request for a team October 22, 2023 15:19
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes in all files

  • removing the width and height attributes
  • adding a newline at end of file

icons/jetpackcompose/jetpackcompose-line-wordmark.svg Outdated Show resolved Hide resolved
icons/jetpackcompose/jetpackcompose-line.svg Outdated Show resolved Hide resolved
icons/jetpackcompose/jetpackcompose-line.svg Outdated Show resolved Hide resolved
icons/jetpackcompose/jetpackcompose-original-wordmark.svg Outdated Show resolved Hide resolved
icons/jetpackcompose/jetpackcompose-original.svg Outdated Show resolved Hide resolved
icons/jetpackcompose/jetpackcompose-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/jetpackcompose/jetpackcompose-plain.svg Outdated Show resolved Hide resolved
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work on this PR!
Thanks again!

@Snailedlt Snailedlt merged commit 3d28c52 into devicons:develop Oct 24, 2023
5 checks passed
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants