Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up solutions blocking further bug discovery #114

Open
szepeviktor opened this issue Apr 14, 2019 · 2 comments
Open

Cleaning up solutions blocking further bug discovery #114

szepeviktor opened this issue Apr 14, 2019 · 2 comments

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Apr 14, 2019

How about

  1. redesigning helpers loading using $this->add_helper outside a class (maybe a static method?)
  2. moving from extract towards wp_parse_args
  3. undefined $user in https://github.com/devgeniem/dustpress/blob/master/models/user-activate.php#L60
  4. introduce TravisCI: syntax check, coding style, static analysis

@Nomafin What do you think?

@szepeviktor szepeviktor changed the title Cleaning up solutions block further bug discover Cleaning up solutions blocking further bug discover Apr 14, 2019
@Nomafin
Copy link
Contributor

Nomafin commented Apr 14, 2019

Hi Viktor!

These suggestions sound good. I'll review your pull request and these questions more accurately in Monday or Tuesday and comment them further then.

@szepeviktor
Copy link
Contributor Author

@Nomafin Static analysis for WordPress was just released: https://packagist.org/packages/szepeviktor/phpstan-wordpress

@szepeviktor szepeviktor changed the title Cleaning up solutions blocking further bug discover Cleaning up solutions blocking further bug discovery Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants