-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import error #29
Comments
Are you using I think there may be an issue with the way I'm currently building the package. |
I'm using Typescript with Next.js. This import code runs on the client:
In case it helps, the actual HLS package runs fine imported this way:
|
Here's a minimal StackBlitz example: https://stackblitz.com/edit/nextjs-bgkcxa?devtoolsheight=33&file=pages/index.js |
Thanks @colinricardo I think I may have found the issue. Going to test it out in a create-react-app and create-next-app to see |
Alright, the issue is going to be a bit more than I'm able to get to at the moment. I'd recommend using version 2.0.0 or 1.1.0 in the meantime. I think I'm going to need to introduce a proper bundler for this. In version 3 I was hoping to shed off some of the heavy configurations needed with webpack and what not, and I'm pretty sure getting rid of webpack is what's causing this issue. Thanks for bringing this too my attention |
Great, thanks! I'll try one of those versions. Let me know if I can help with anything :) |
Version 2.0.0 working great, thanks! |
If you're familiar with creating react packages with typescript and might be able to point me in the right direction that'd be helpful. I'm reading through some articles trying to figure out the best way for compatibility. |
React +Nextjs latest version + react-hls latest = Not working: import error.. |
Same here |
@yuri-devi @iMJumpmxn I'm not sure when I'll get a chance to look in to this. In the meantime, you should be able to |
Same issue here, using const Player = dynamic(
() => import('react-hls-player'),
{ ssr: false },
); |
@tgwow I was thinking this may be the case, but haven't had the time to look in to it. Thanks for sharing! |
Using Dynamic import in Next.js helped 😃 |
@tgwow thanks for sharing this Dynamic Import Solved my build issue |
trying to run the very basic example:
and getting this error 🤔
The text was updated successfully, but these errors were encountered: