From 9a1d24b27b2d1ea8916ebe49c9ce674375dced27 Mon Sep 17 00:00:00 2001 From: Daniel Braun Date: Sat, 6 Jan 2024 09:46:25 +0200 Subject: [PATCH] gh-release requires git as part of the install process (#570) --- src/gh-release/devcontainer-feature.json | 2 +- src/gh-release/install.sh | 2 +- test/gh-release/scenarios.json | 10 ++++++++++ test/gh-release/test_no_git.sh | 9 +++++++++ 4 files changed, 21 insertions(+), 2 deletions(-) create mode 100755 test/gh-release/test_no_git.sh diff --git a/src/gh-release/devcontainer-feature.json b/src/gh-release/devcontainer-feature.json index 734b4c352..2cc0ea2a6 100644 --- a/src/gh-release/devcontainer-feature.json +++ b/src/gh-release/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "gh-release", - "version": "1.0.24", + "version": "1.0.25", "name": "Github Release", "documentationURL": "http://github.com/devcontainers-contrib/features/tree/main/src/gh-release", "description": "Github Release feature will download, extract and add to path a release binary from a given repo", diff --git a/src/gh-release/install.sh b/src/gh-release/install.sh index 12bc96d40..172cc52fb 100755 --- a/src/gh-release/install.sh +++ b/src/gh-release/install.sh @@ -8,7 +8,7 @@ set -e # `ensure_nanolayer` is a bash function that will find any existing nanolayer installations, # and if missing - will download a temporary copy that automatically get deleted at the end # of the script -ensure_nanolayer nanolayer_location "v0.5.5" +ensure_nanolayer nanolayer_location "v0.5.6" diff --git a/test/gh-release/scenarios.json b/test/gh-release/scenarios.json index 452dd188c..461967d2b 100644 --- a/test/gh-release/scenarios.json +++ b/test/gh-release/scenarios.json @@ -62,5 +62,15 @@ "additionalFlags": "--no-filter-assets-by-platform" } } + }, + "test_no_git": { + "image": "ubuntu", + "features": { + "gh-release": { + "version": "latest", + "repo": "Azure/aztfexport", + "binaryNames": "aztfexport" + } + } } } \ No newline at end of file diff --git a/test/gh-release/test_no_git.sh b/test/gh-release/test_no_git.sh new file mode 100755 index 000000000..36c09684c --- /dev/null +++ b/test/gh-release/test_no_git.sh @@ -0,0 +1,9 @@ +#!/bin/bash -i + +set -e + +source dev-container-features-test-lib + +check "aztfexport --version" aztfexport --version + +reportResults