Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all errors using snackbar #44

Open
tmibvishal opened this issue May 28, 2020 · 5 comments
Open

Show all errors using snackbar #44

tmibvishal opened this issue May 28, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@tmibvishal
Copy link
Member

A lot of places have used errors like print(e)
Use snackbar at those places so that user can also get to know about those errors

@tmibvishal tmibvishal added the enhancement New feature or request label May 28, 2020
@pr4nshul
Copy link

pr4nshul commented Nov 5, 2020

hey, I am new to open-source and to flutter. I would like to contribute to this feature but I would need a little guidance. I know about snackbar and I understand the issue, that you need to display error not only on the console but also on the device of the user.

@arpit-saxena
Copy link
Member

Hi Pranshul, great to see you're eager to contribute to our repository. Here is a roadmap I would suggest:

  • As is common for most projects, the first step would be to clone the repository and get it working on your system. Use a virtual or physical device, and get the app built and running.
  • After that, you should try to familiarize yourself with the codebase. Just a high level understanding of what is happening is where is sufficient. You can look through the README for some guidance.
  • Getting to this particular issue, you would then have to see in which places in the codebase can an error occur. If it's not getting reported, report it through the snackbar. Open a PR when you have done so, we'll review it :)

Feel free to ask for clarifications or further doubts.

@pr4nshul
Copy link

pr4nshul commented Nov 9, 2020

So, I was reading the codebase, and adding a snackbar for error should be easy. Though what I found is at many places it is mentioned whether snackbar is needed in inline comments. But I also found places where catch(error) is present but no in-line comments for that functionality. So, should I leave those catch blocks?

@kshitijalwadhi
Copy link
Member

Hi Pranshul,
You can add the functionality of showing a snackbar at all the places where there is a try catch block irrespective of whether there is a comment stating to add one or not.

@pr4nshul
Copy link

Hey, I have made a PR, please review it and tell me if any changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants