Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some thumbnails are skipped #21

Open
escapezn opened this issue Apr 12, 2022 · 9 comments
Open

Some thumbnails are skipped #21

escapezn opened this issue Apr 12, 2022 · 9 comments

Comments

@escapezn
Copy link

Hello,

At first I found some thumbnails would not appear as cursor hovering over the progress bar. I suspected that 120 thumbnails are too much to be shown so tired 60 but it still behave incorrectly. I also tired toggling ffmpeg to mpv, and accurate_seek option, but all turned out the same. This is confusing and there maybe something wrong with the script, please have a look at it.

video1, 120 thumbnails
https://user-images.githubusercontent.com/30799958/162909156-72e9d6c0-47ec-4b71-a100-d0789a89ca93.mp4

video1, 60 thumbnails
https://user-images.githubusercontent.com/30799958/162912721-ebc0ec9e-fab0-4f03-8f4e-c55c379e358e.mp4

video2, 60 thumbnails, accurate_seek=yes
https://user-images.githubusercontent.com/30799958/162913577-b074c733-5e72-4a4b-b2f1-96de58878698.mp4

@deus0ww
Copy link
Owner

deus0ww commented Apr 12, 2022

If this is running on a slow machine, try upping worker_timeout.

@escapezn
Copy link
Author

worker_timeout=0 is configured and it didn't help. The output in console is normal even if worker_timeout is in default value.

[Thumbnailer] Worker Finished (uncounted): Thumbnailer_Worker {"queued":40,"success":40,"failed":0,"name":"Thumbnailer_Worker","existing":0}
AV: 00:00:22 / 00:24:09 (2%) A-V:  0.000
[Thumbnailer] Worker Finished (uncounted): Thumbnailer_Worker3 {"queued":40,"success":40,"failed":0,"name":"Thumbnailer_Worker3","existing":0}
AV: 00:00:22 / 00:24:09 (2%) A-V:  0.000
[Thumbnailer] Worker Finished (uncounted): Thumbnailer_Worker2 {"queued":39,"success":39,"failed":0,"name":"Thumbnailer_Worker2","existing":0}

@escapezn
Copy link
Author

escapezn commented Apr 12, 2022

0=No Timeout (Linux or Mac w/ coreutils installed only)

Sorry I ignored this.

Unfortunately a considerable value like 50 didn't make sense, either.

@deus0ww
Copy link
Owner

deus0ww commented Apr 12, 2022

Can you post the full mpv log?

Additionally, I would be helpful if you can add this to your input.conf: KEY script-message Thumbnailer-debug. Press KEY before saving the log file.

@escapezn
Copy link
Author

mpv.log

@escapezn
Copy link
Author

BTW, this is config of thumbnail script.

#  MPV - thumbnailer.conf
#  deus0ww - 2021-05-27

# General
auto_gen=no
auto_show=no
auto_delete=2
start_delay=0

# Paths
# cache_dir=/Users/Shared/Library/Caches/mpv/thumbnails
# worker_script_path=$MPV_HOME\scripts

# Thumbnail
dimension=400
# thumbnail_count=150
min_delta=5
max_delta=90
remote_delta_factor=1
#stream_delta_factor=2
bitrate_delta_factor=1
#bitrate_threshold=8

# OSC
#spacer=2
show_progress=2
#centered=yes
#update_time=0.25

# Worker
# max_workers=4
worker_remote_factor=1
#worker_bitrate_factor=1
#worker_delay=1
# worker_timeout=50
#accurate_seek=yes
use_ffmpeg=yes
prefer_ffmpeg=yes
#ffmpeg_threads=1
ffmpeg_scaler=fast_bilinear

@deus0ww
Copy link
Owner

deus0ww commented Apr 13, 2022

Can you try running the debug function after the thumbnail generation is done and post the log again?

@escapezn
Copy link
Author

escapezn commented Apr 13, 2022

mpv1.log

@deus0ww
Copy link
Owner

deus0ww commented Apr 13, 2022

The is really perplexing... there doesn't seem to be anything wrong...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants