Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need support for smaller viewheights + certain phones #42

Open
phillipson808 opened this issue Jun 20, 2019 · 3 comments
Open

Need support for smaller viewheights + certain phones #42

phillipson808 opened this issue Jun 20, 2019 · 3 comments

Comments

@phillipson808
Copy link
Contributor

The content bleeds off the screen into whitespace if the vertical size of the screen is shortened.

@japamat0
Copy link
Contributor

japamat0 commented Jun 20, 2019

talked to @phillipson808 about this, but we can use overflow: scroll on the top-level panel component classes, e.g. .Burst, .Settings, etc.

Also, for some of the components the bottom most element may need some bottom padding, e.g. on the <Burst /> component, the .Burst-button could change margin-top: 10px; to margin: 10px auto; to add a little space below when the window height is less than the component's total height.

@alissarenz - would it make sense to include other issue's that are small css fixes here as well? issue #40 (Align Oversample checkbox) for example?

@japamat0
Copy link
Contributor

japamat0 commented Jun 20, 2019

It might make sense to include viewwidth adjustments here too, particularly for the preview component - on the old iPhone 5/SE & Galaxy S5 the .Preview > .Frame div runs off the sides, we could scale down the height and width to fit here, seems to be aligned with the goal of this issue

@phillipson808
Copy link
Contributor Author

I'll check on responsiveness and fix what I can

@phillipson808 phillipson808 changed the title Need support for smaller viewheights Need support for smaller viewheights + certain phones Jun 20, 2019
misscoded added a commit to rithmschool/gifsmos that referenced this issue Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants