Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Little loading blue icon is rendered behind the menu #1664

Open
felipecrs opened this issue Oct 26, 2024 · 10 comments
Open

Little loading blue icon is rendered behind the menu #1664

felipecrs opened this issue Oct 26, 2024 · 10 comments
Labels
feature New feature or request

Comments

@felipecrs
Copy link
Contributor

Description of problem:

When menu is not outside, the little loading blue icon that shows when a still image is being displayed before the live stream is fully loaded is rendered behind the menu. I believe it should be rendered below the menu.

image

@felipecrs felipecrs added the bug Something isn't working label Oct 26, 2024
@dermotduffy
Copy link
Owner

This would actually be non-trivial to implement, since it would require the live provider code knowing where the browser rendered the menu. I had been thinking about moving it into the status bar though (I think you usually have that disabled, but it's enabled by default and feels like a good place for this, downside is that people who disable the status bar would not see this little indication that the "real stream" isn't loaded).

@felipecrs
Copy link
Contributor Author

felipecrs commented Oct 26, 2024

Status bar seems like a reasonable place for such information indeed.

Another option would be to dim the icon opacity, make it grey, and center it in the image.

@felipecrs
Copy link
Contributor Author

Another option would be to dim the icon opacity, make it grey, and center it in the image.

Or maybe it won't look good. lol

@dermotduffy
Copy link
Owner

Status bar seems like a reasonable place for such information indeed.

On reflection, I'm not sure, as in grid mode there'll be multiple cameras loading at the same time. A single "loading" icon in the status bar is probably not as useful as the way it is right now. Ultimately it's a per-camera property.

Or maybe it won't look good. lol

I tried it. Yeah, doesn't look great :-( I'm inclined to either leave this as-is, or optionally make it configurable, but not sure it's worth another option really.

@dermotduffy dermotduffy added feature New feature or request and removed bug Something isn't working labels Nov 28, 2024
@felipecrs
Copy link
Contributor Author

felipecrs commented Nov 28, 2024

This would actually be non-trivial to implement, since it would require the live provider code knowing where the browser rendered the menu.

Can't it be more static? For example, couldn't it analyze the configuration to detect whether the menu is not external, its height, and then rendering the blue icon some pixels below it?

@dermotduffy
Copy link
Owner

Can't it be more static? For example, couldn't it analyze the configuration to detect whether the menu is not external, its height, and then rendering the blue icon some pixels below it?

Technically yes, anything is possible, but this would break the web component encapsulation. The live rendering (which tells whether the provider is loaded or not) doesn't know anything about the menu.

@felipecrs
Copy link
Contributor Author

I see.

I'm inclined to either leave this as-is, or optionally make it configurable, but not sure it's worth another option really.

Yes, I agree this isn't big deal. There are more important things to worry about.

Feel free to close this issue then, or not.

@felipecrs
Copy link
Contributor Author

@dermotduffy maybe it should just be rendered in the opposite corner compared to the menu? (it'd still need some information about the menu itself, but I see no other solution without it).

@dermotduffy
Copy link
Owner

@dermotduffy maybe it should just be rendered in the opposite corner compared to the menu? (it'd still need some information about the menu itself, but I see no other solution without it).

I think that is roughly equivalent to:

  • Add a new option that controls which corner it shows up in.
  • By default that option is auto
  • If auto, the card looks at where the menu is and puts it not there, then simply tells the live view to use that (so the live view doesn't actually need to know anything about the menu directly).

One issue is that if you had the menu at the top, and the status bar at the bottom, there really isn't a good answer here, other than perhaps (i) as it is, or (ii) the center...

@felipecrs
Copy link
Contributor Author

If auto, the card looks at where the menu is and puts it not there, then simply tells the live view to use that (so the live view doesn't actually need to know anything about the menu directly).

If that works, then a new option would not even be necessary.

One issue is that if you had the menu at the top, and the status bar at the bottom, there really isn't a good answer here, other than perhaps (i) as it is, or (ii) the center...

If the card will analyze the menu's location and then tell live view where to put the icon, then I think the card can just analyze whether the conditions below, tell live view to position the blue icon in a position which is immediately below the menu.

  1. In case the menu is not external
  2. In case it's visible
  3. In case it's at the top

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants